Skip to content

feat(compute): add terraform sample for instanceflexibilitypolicy of rmig #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2024
Merged

feat(compute): add terraform sample for instanceflexibilitypolicy of rmig #756

merged 5 commits into from
Nov 19, 2024

Conversation

@chayankumar999
Copy link
Contributor

@chayankumar999 chayankumar999 commented Nov 5, 2024 •
edited
Loading

Description

Fixes #333070003

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@chayankumar999 chayankumar999 requested review from a team as code owners November 5, 2024 13:47
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 5, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@snippet-bot
Copy link

snippet-bot bot commented Nov 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@chayankumar999 chayankumar999 marked this pull request as draft November 5, 2024 13:47
@chayankumar999 chayankumar999 changed the title Add InstanceFlexibilityPolicy terraform sample for RMIG feat(compute): RMIG InstanceFlexibilityPolicy Nov 5, 2024
askubis
askubis approved these changes Nov 5, 2024
View reviewed changes
@glasnt
Copy link
Contributor

glasnt commented Nov 5, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Nov 6, 2024

FYI: I know this PR isn't ready for review yet, but you're getting this error:

The argument "base_instance_name" is required, but no definition was found.

@chayankumar999 chayankumar999 force-pushed the chayanr-flexibility-policy branch 2 times, most recently from 08a80d9 to 9680657 Compare November 6, 2024 10:49
@chayankumar999
Copy link
Contributor Author

chayankumar999 commented Nov 6, 2024

FYI: I know this PR isn't ready for review yet, but you're getting this error:

The argument "base_instance_name" is required, but no definition was found.

Done!

@chayankumar999 chayankumar999 marked this pull request as ready for review November 6, 2024 10:51
@chayankumar999 chayankumar999 force-pushed the chayanr-flexibility-policy branch 2 times, most recently from 89b32fe to 21d0eeb Compare November 6, 2024 11:34
@chayankumar999 chayankumar999 changed the title feat(compute): RMIG InstanceFlexibilityPolicy feat(compute): add terraform sample for instanceflexibilitypolicy of rmig Nov 6, 2024
@chayankumar999 chayankumar999 force-pushed the chayanr-flexibility-policy branch 2 times, most recently from 902406f to dbff329 Compare November 6, 2024 12:12
@chayankumar999 chayankumar999 force-pushed the chayanr-flexibility-policy branch from dbff329 to 63a93ce Compare November 18, 2024 23:54
@chayankumar999 chayankumar999 force-pushed the chayanr-flexibility-policy branch from 63a93ce to e94837a Compare November 19, 2024 10:25
@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

The tests in this PR pass only when I use the 6.12 google-beta provider; is this intended?

(The use of this version is causing crashes elsewhere)

@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

/gcbrun

@chayankumar999
Copy link
Contributor Author

chayankumar999 commented Nov 19, 2024

The tests in this PR pass only when I use the 6.12 google-beta provider; is this intended?

(The use of this version is causing crashes elsewhere)

The terraform feature is still not available GA. As I can see, you added the provider along with version. That means when the GA will be available, I have to submit another PR with mentioning the google provider. Is it so?

@glasnt glasnt enabled auto-merge (squash) November 19, 2024 23:01
@glasnt
Copy link
Contributor

glasnt commented Nov 19, 2024

When this functionality is in the main google provider (not just google-beta), there will need to be a change to (currently) line 31 to specify google rather than google-beta.

This information is outside the region tags, so the contents of the sample will remain the same pre and post GA

@glasnt glasnt merged commit 111bee7 into terraform-google-modules:main Nov 19, 2024
5 checks passed
@chayankumar999
Copy link
Contributor Author

chayankumar999 commented Nov 19, 2024

tags

Got it.
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glasnt glasnt glasnt approved these changes

+1 more reviewer

@askubis askubis askubis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chayankumar999 @glasnt @askubis